QR code component page

👾Hello Damian, congratulations for your new solution!

Answering your question:

Its better you use px/rem instead of % for the radius, because if you use percentage this will consider the elements size and the border radius will vary depending of the element. Think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

✌️ I hope this helps you and happy coding!

Hi Damian,

Welcome to the frontend mentor community and congratulations 🎉 for completing this challenge, it was a great attempt. I found some issues I want to address:

1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
2. You should also wrap your footer within the footer tag e.g. <footer class="attribution></footer>
3. To center the card in the middle, you need to remove the margin property that is set on .card

Overall, great attempt and wish you the best for your future projects so keep coding 👍.