Design comparison
Solution retrospective
My friends,
- Visit my solution and give me feedback so that i can improve
Community feedback
- @Bishalsnghd07Posted 9 months ago
Hi @bScripter
Congrats for completing this challenge🎉
A few suggestions for you, might it be helpful.
1)Never ever use height in your main landmark, it will only break your layout. You can be use
min-height: 100vh
instead ofheight: 100vh
. Giving height and width in main landmark means, you are giving height & width in your html body, not in your specific component. By giving height: 100vh; means you are preventing your viewport screen size of your total screen. Apart from that everything is fine.2)Second If you want to check the performance of your web page, then I would recommend to use lighthouse testing tool, what you have to do is you just have to inspect in your web page, in which you are currently working and after inspecting you will see a many option and one of the option you will be getting that is lighthouse, just click on it and test your web page run time performance, best practices and many more. It's a great tool and helps to identify web page issues related best practices, bugs and it enhance the efficiency of web page.
Hope, this suggestion will help you!
Marked as helpful0@bScripterPosted 9 months agoThank you bro @Bishalsnghd07 I am a newbie stepping with love to front end development. Thanks to the suggestion it will help me a lot. I will improve accordingly. Also do suggest in my upcoming solutions. Thank you
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord