Qr code component page

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Mahmoud, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • use h1 for the title of card and not h3
  • instead of using height use min-height: 100vh to container class
  • add a little transition on the element with hover effect
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  1

  ---

  

  Mahmoud ELshora•40

  @elshoraPosted over 2 years ago

  @denielden thanks for the tips I will work on it

  1