@Hassiai
Posted
Replace <div class="card"> with the main tag, <h4> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/
To center .card on the page page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
For a responsive content use max-width instead of width. you won't require a media query for this challenge when you use the max-width.
There is no need to give .card and img display: inline-block. Give the max-width of .card a fixed value instead of a percentage value.
Give img a max-width of 100%, there is no need to give img a padding value but rather give .card a padding value for all the sides for the space between it and its content.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful HAPPY CODING
Marked as helpful
@akash4102
Posted
@Hassiai thanks to review my code and some helpful suggestions
@Hassiai
Posted
@akash4102 if you find my comment helpful mark it as helpful
@VCarames
Posted
@Hassiai
Please avoid the following as it is against FEM’s policy:
- "if you find my comment helpful mark it as helpful"
Which can result in your getting account flagged and ban temporarily or permanently.
"Ask people to mark your comment as helpful — A big part of Frontend Mentor is helping each other out and providing feedback. If you give some feedback, please avoid saying things like, "if you found this feedback useful, please mark this comment as helpful". It places unnecessary pressure on the solution author to mark your comment as helpful, which is best avoided. Feel free to say something like, "I hope you find this helpful", but please avoid asking for your comment to be marked as helpful outright."
Remember, it’s about helping each other grow and become better developers, not about getting points.
Thank you for contributing to the FEM community!
Happy Coding!🎄🎁
@Hassiai
Posted
@vcarames Thank you :)