QR Code Component

Community feedback

• 

  Karishma Garg•1,010

  @karishma-devPosted over 2 years ago

  Hey, your solution looks good. Few suggestions:

  1. You haven't closed the link tag for importing the stylesheet, due to which you are having some HTML issues.
  2. Provide alternate text for images so if a person using accessible technologies or due to some reason cannot see the image, they will know what the image is about by reading this text.
  3. Your card is not properly centered. Add display: flex; justify-content: space-between; align-items: center; flex-direction: column; min-height: 100vh; to the body. In this, justify-content will make sure there is some space between your elements and align-items will align the content to the center. Remove min-height: 100vh from your main tag, as it's causing the browser to have a scrollbar.
  4. Add your "Frontend Mentor | QR code component" text in a tag, and add some margin-top to it. Also, add some margin-bottom in your footer so there is some space between the footer and the end of the page. (This will make the design of your page look better).

  Hope this helps! :)

  Marked as helpful

  0

  ---

  

  Ashley Serrano-Ziel•70

  @aszcodingPosted over 2 years ago

  @krrish105 thanks so much for reviewing my code and for the feedback! I've made adjustments, and now my report comes back with zero issues found.

  Thanks again! :)

  1