Skip to content
Submitted over 2 years ago

QR code component

Jesus Rebeitte•110
@Rebeitte
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any advice is welcome :D

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @Rebeitte, Congratulations on completing this challenge!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    Something I've noticed in your code is that on many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, which can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Jesus Rebeitte•110
    @RebeittePosted about 2 years ago

    @correlucas Thank you Lucas! yes I was learning how to use semantic html5, that's why I used too many divs.

    0
  • Travolgi 🍕•31,400
    @denieldenPosted over 2 years ago

    Hi Jesus, great work on this challenge! 😉

    Here are a few tips for improve your code:

    • add descriptive text in the alt attribute of the image
    • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
    • remove all margin from main class because with flex they are superfluous
    • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
    • instead of using px use relative units of measurement like rem -> read here

    Overall you did well 😁 Hope this help!

    Marked as helpful
    1
    Jesus Rebeitte•110
    @RebeittePosted over 2 years ago

    @denielden thank you so much! Great advices, this helps a lot! I will improve the next time

    1
  • Rimi coder•20
    @One-RMPosted over 2 years ago

    Nice work bem!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord