QR component using Grid and flexbox

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi! Great solution!

  Almost nothing to add except just a few things

  • alt should describe an image or its function and only be empty if an image is for decoration. In this challenge alt should be QR code to frontendmentor.io
  • I used the font hack too, but Melvin Aguilar provided feedback that it's better not to use this. Here is the article
  • I'm not sure about this, but I wouldn't use flexbox that much. Why? I have no idea. 😁 But feedback on my feedback would be appreciated

  Have a nice day!

  Marked as helpful

  0

  ---

  

  Chris Jay•220

  @chrisjay358Posted almost 2 years ago

  @rostyslav-nazarenko Thank you for taking the time to give some feedback.

  • For the alt i almost forgot to put that, thank you for reminding me, I've corrected that.
  • For the font hack I also saw something in Kevin Powell's YouTube channel that right now everything is turning to base 16. You know the 10 makes it easy to do calculations, some of us suck at math and are lazy to open calculators. Might take a hard time going back to base 16. I would read the article.

  Thank you, do make to drop more feedbacks*

  1