Design comparison
Community feedback
- @ajeetachalPosted about 1 year ago
Your HTML and CSS code looks quite clean and well-structured. However, I can provide some suggestions to make it even cleaner and more organized:
CSS Cleanup:
1.You have defined the img selector twice in your CSS. You can combine them into one declaration.
2.Use consistent naming conventions for CSS variables. For example, use --light-gray instead of --Light-gray.
3.Organize your CSS rules by grouping them logically (e.g., typography, layout, colors) to improve readability.
4.Consider using more descriptive class names if the project grows.
HTML Structure:
- Consider adding a lang attribute to the <html> element for specifying the document's language.
2.You can move the CSS <link> and favicon <link> from the <head> to just before the closing </body> tag. This helps improve page loading performance.
<html lang="en"> <head> <meta charset="UTF-8"> <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <title>Frontend Mentor: QR Component</title> </head>```0@uj-ujjawalPosted about 1 year ago@ajeetachal
Thank you for your feedback and suggestions for improving the cleanliness and organization of the HTML and CSS code. I appreciate your input, and I'll implement these improvements to ensure cleaner and more organized code.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord