QR code component

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 7 months ago

  Hi Nichole, well done. Here are some tips :)

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • The alt text must also say where it leads(frontendmentor website).

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Remove the html selector.

  • Remove the height on body.

  • Remove the margin on the card.

  • To center the card horizontally and vertically, use Flexbox on the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100svh;
  

  • Remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • Remove the positioning and transform properties on the card.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove the margin.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card: padding: 16px;.

  Marked as helpful

  0
• 

  tommy flinch•100

  @tflinchPosted 7 months ago

  Code is spot on and responsive! Consider looking into display flex. It's a nice alternative from using position absolute.

  Marked as helpful

  0
• 

  rozinsrjr262•20

  @rozinsrjr262Posted 7 months ago

  helpful

  0