QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Wrap the page's whole main content in the <main> tag.

  • In this challenge, it's not necessary to use media queries for responsiveness. You can directly apply styles like max-width: 400px; to the component. The only issue I see in your solution is that you have inline styles in your HTML (style="width: 22rem; height: 34rem;"), and these inline styles take precedence, potentially overriding all styles from your CSS file. Be cautious with inline styles as they can interfere with the external style sheet.

  • Maintain a clear heading hierarchy, starting with <h1> and progressing through levels (<h2>, <h3>, etc.). Source 📘

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0