QR Code Component

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 5 months ago

  @DJTwoTone

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • Add a bit of padding to your body element so the card has room to breath on smaller viewports.

  • Try styling your elements using classes instead of ID's.

  • Try giving your elements more descriptive classes like .card, .card-title and .card-description.

  • I recommend against setting a fixed height and width on elements because you will run into overflow issues.

  • block elements like body already take up the full width of their parent by default, so you can remove width: 100vw.

  • Try setting min-height: 100vh on your body so it takes up the full height at a minimum while still being able to grow if the content inside it grows.

  • Try using CSS variables to make your CSS values more reusable.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0