Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

@DJTwoTone

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@DylandeBruijn

Posted

@DJTwoTone

Hiya! 👋

Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

Things you could improve ✍️

  • Add a bit of padding to your body element so the card has room to breath on smaller viewports.

  • Try styling your elements using classes instead of ID's.

  • Try giving your elements more descriptive classes like .card, .card-title and .card-description.

  • I recommend against setting a fixed height and width on elements because you will run into overflow issues.

  • block elements like body already take up the full width of their parent by default, so you can remove width: 100vw.

  • Try setting min-height: 100vh on your body so it takes up the full height at a minimum while still being able to grow if the content inside it grows.

  • Try using CSS variables to make your CSS values more reusable.

I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

Happy coding! 😎

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord