Skip to content
Submitted over 1 year ago

QR Code Component

thiha naing•150
@thihaNg
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Ecem Gokdogan•9,380
    @ecemgoPosted over 1 year ago

    Some recommendations regarding your code that could be of interest to you.

    HTML

    In order to fix the accessibility issues:

    • You need to replace <div class="container"> with the <main> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.

    • Another issue is that your <img> tag should include alt ="" attribute. You can apply like this:

    <img src="./images/image-qr-code.png" alt="qr-code"/>
    • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using <h4>. You can replace your <h4>Improve your front-end skills by building projects</h4> element with the <h1>Improve your front-end skills by building projects </h1> element.
    • For the font-family to work correctly, add the following between the <head> tags in HTML file:
    <link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet">

    CSS

    • You can add font-family and update your background color in your body in this way:
    body {
   font-family: 'Outfit', sans-serif;
   background: #d6e2f0;    // the color which is recommended
}

    Hope I am helpful. :)

    Marked as helpful
    1
    thiha naing•150
    @thihaNgPosted over 1 year ago

    @ecemgo Thank you for your recommendations. I will work on that.

    1
    Ecem Gokdogan•9,380
    @ecemgoPosted over 1 year ago

    @thihaNg I'm happy to help! 🎉

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord