QR CODE CHALLENGE

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="qr"> with the main tag,<br> with <h1> and <div class ="text2"> with <p>, <div class="attribution"> with the footer tag and it should be out of <div class="qr"> to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Use the colors and font-family that were given in the styleguide.md found in the zip folder you downloaded

  To center .qr on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units click here

  Give the img a max-width of 100% instead of a width and height value. For a responsive content, replace the width of .qr with max-width and a height with padding value for all the sides.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1
• 

  Shantanu sahay•40

  @shan0720-creatorPosted almost 2 years ago

  Thankyou so much , i now know that i have to make a exact replica of this project

  0