QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @efeaizesogie 👋, good job on completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Instead of using <section class="section"> to wrap the whole content, use <main> tag.

  • Additionally, you can use the <article> tag instead of div to the container card: <div class="card">.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • To make alternative texts more useful, add descriptive text to the alt attribute of the QR image to explain what the QR image does.

  • The alternative text must not contain hyphens, underscores, or the words "image" or "photo", it must be human readable.

  • Use min-height: 100vh to the "section" selector instead of height. This property lets you set a height and let the element grow even more if necessary.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  efe aizesogie•90

  @efeaizesogiePosted about 2 years ago

  @MelvinAguilar thanks a lot I have implemented all these and I will try to work with it henceforth. one question, for the alt text can I write a long description.

  1

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  @efeaizesogie Hi, It is not necessary, it would be enough with "QR code to frontendmentor.io". You can read more about alternative text here.

  Marked as helpful

  1