Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-card components using HTML5 and CSS flexbox

Mako 360

@MakoDoli

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace<div class="qr-container"> with the main tag and <h2>with <h1> to fix the accessibility issue.

Change the height: 100vh to min-height: 100vh; to center .qr-container using flexbox.

Replace the height value in .qr-container with a padding value for all the sides. give the img a max-width of 100% instead of a width and height values.

There is no need fo .qr-paragraph and .qr-heading in the html and in the css. Give p and h1 the same padding-left and padding-right values and the same margin-top values.

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord