QR Code Component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Franco, congratulations for your new solution!

  👏 Great start and great first solution! You’ve done really good work here putting everything together. Your solution is really complete and fully responsive. The only advice I have for you is about using a CSS RESET, because something that can be a time saver for you is to use this CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Franco Juarez•220

  @JuarrisonPosted about 2 years ago

  Hello, @correlucas. Thank you very much for your comment. I'm going to review the documentation you sent me to improve the implementation of the code. Greetings and good start to the week.

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Great job on the challenge, just few suggestions on the body rule add min-height: 100vh to center the card on the page and on the card you can make the following adjustments just to scale the card down.

  article {
      max-width: 280px;
      padding: 1rem;
  }
  
  The max-width you can play width until you feel it is similar to that of the design.
  
  Hope that helps.
  

  Marked as helpful

  0

  ---

  

  Franco Juarez•220

  @JuarrisonPosted about 2 years ago

  Hi @hyrongennike. I just tried the changes you suggested and I think it has improved the design of the challenge. Thank you very much for your observation, I will update the challenge shortly.

  0