Skip to content
Submitted 9 months ago

QR Code Component (Newbie) using CSS custom properties

Kaushal Kishoreā€¢150
@KaushalSonic
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud that I'm started the journey of actual implementing given task from the design.

What challenges did you encounter, and how did you overcome them?

No challenges faced

What specific areas of your project would you like help with?

I need help with implementing proper width and height of the container.

Community feedback

  • Daniel šŸ›øā€¢44,250
    @danielmrz-devPosted 9 months ago

    Hello @KaushalSonic!

    Your solution looks great!

    I have a suggestion for improvement:

    • Use <main> to wrap the main content instead of <div>.

    šŸ“Œ Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

    This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    1
    Kaushal Kishoreā€¢150
    @KaushalSonicPosted 9 months ago

    @danielmrz-dev Thanks for your view, but I had solution for that I used role=main in that div also I used main tag instead of div in the next challenge that is Blog Preview Card. :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord