qr code component

Community feedback

• 

  Petros Devrikis•380

  @PetrosdevriPosted over 1 year ago

  Great work, I think you could maybe make the height a bit larger or increase padding to leave more space available for the image. You may also want to follow the accessibility advice as it's a great way to use ARIA labels or roles to help disabled people. But overall nothing special, keep going!

  0

  ---

  

  Brijeshkumar Patel•200

  @brijeshkumar001Posted over 1 year ago

  @Petrosdevri thank you

  0
• 

  Esther Rose•150

  @codarosePosted over 1 year ago

  Great solution!

  There are definitely fewer options when it comes to responsive height, however "vh" units which you used are a good option. You can also create media queries that target viewport height, and there is a media query for landscape orientation if you are designing for that use case on mobile.

  0

  ---

  

  Brijeshkumar Patel•200

  @brijeshkumar001Posted over 1 year ago

  @codarose thank you

  0

  

  Fawas•0

  @Kay-fawazPosted over 1 year ago

  @brijeshkumar001 please can you explain to me how you submit this practice , have been facing issues with the submission.

  0

  

  Brijeshkumar Patel•200

  @brijeshkumar001Posted over 1 year ago

  @Kay-fawaz please go through this-article

  0