Hi there Iām Brijeshkumar and this is my solution for this challenge. š
Please suggest me way to create responsive heights of the elements
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. šāļø
@Petrosdevri
Posted
Great work, I think you could maybe make the height a bit larger or increase padding to leave more space available for the image. You may also want to follow the accessibility advice as it's a great way to use ARIA labels or roles to help disabled people. But overall nothing special, keep going!
@brijeshkumar001
Posted
@Petrosdevri thank you
@codarose
Posted
Great solution!
There are definitely fewer options when it comes to responsive height, however "vh" units which you used are a good option. You can also create media queries that target viewport height, and there is a media query for landscape orientation if you are designing for that use case on mobile.
@brijeshkumar001
Posted
@codarose thank you
@Kay-fawaz
Posted
@brijeshkumar001 please can you explain to me how you submit this practice , have been facing issues with the submission.
@brijeshkumar001
Posted
@Kay-fawaz please go through this-article
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
