QR code component

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hi A S Irfan Ahmed, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  Every Html document must contain the main tag, so we can identify the main content, to fix this, wrap the main content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  Avoid using px, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem

  To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5

  <h1 class="heading">Improve your front-end skills by building projects</h1>

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  A S Irfan Ahmed•160

  @coding-sagarPosted almost 2 years ago

  @AdrianoEscarabote thanks

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Irfan, You have done a good work! 😁

  Some little tips to improve your code:

  • to make it look as close to the design as possible set width: 22rem to main tag
  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use h1 for the title of card and not a simple p
  • remove all margin from main tag because with flex they are superfluous
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  A S Irfan Ahmed•160

  @coding-sagarPosted almost 2 years ago

  @denielden thanks

  0

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @coding-sagar You are welcome and keep it up :)

  Marked as helpful

  0