Huy Phan• 1,940
@huyphan2210
Posted
Hi, @Zahid9985
I checked out your solution and I have some thoughts:
- Frontend Mentor provides a feature to review your HTML after submission. It may highlight errors or warnings, so try resolving these for a cleaner solution.
- For better semantic HTML, consider using meaningful elements instead of
divs. For example,.containercould be amainelement, and other sections can use more descriptive tags. - Your card heading uses an
h2, but there’s noh1on the page. Ideally, every page should start with anh1to establish a clear heading hierarchy, which improves both accessibility and readability. - You’ve used fixed
widths andheights throughout, which can limit responsiveness. I’d recommend exploring responsive design techniques, such as media queries, CSS relative units (likeem,rem, and%), built-in functions (clamp,calc,min,max), and concepts like the mobile-first approach. - The challenge design doesn’t include a gradient, nor did you add one. It’s usually best to focus on matching the provided design first before adding extra elements.
Hope this helps!
1
