QR code component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Giridharan, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Replace the <div> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in level of importance, never jump a level.

  3.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  0
• 

  Luz De La Rosa•100

  @luztherosePosted about 2 years ago

  Hi Giridharan 👋🏾

  Congratulation on completing this challenge. Your solution looks great. I have some tips regarding your solution if you don’t mind:

  • When writing your HTML always try to use semantics elements whenever possible. For example header, main, h1, p, footer, instead of divs.

  • The text for the alt="QR" attribute tries to make it as descriptive as possible since this is the text that will be displayed if the image cannot be loaded. for example alt="This is a QR code to frontend mentor".

  • For naming your stylesheet, you could use a more standard name like style.css(optional)

  Overall Excellent work! Hopefully, this feedback helps.

  0