QR code component

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Nugget, great job getting the solution for the challenge, welcome to the Frontendmentor community

  In this challenge there is actually no need to adapt that much from mobile to desktop, just using only max-width should do the job, I checked out your code and noticed that you were using max-width and min-width in the same place with the same value, try avoiding this because using both tags would be the same as just using width, in this case it would be better to use max-width on the whole container, so your component adapts on lower screens.

  Hope my feedback helps you, if you have any questions don't hesitate to ask!

  Marked as helpful

  1

  ---

  

  Nugget•60

  @NuggxtPosted about 2 years ago

  @DavidMorgade I will definitely keep this in mind as i go forward in learning. TBH I thought I took out the min-width. I guess it got passed me when i uploaded the files to github. Thank you so much for the feedback!

  1