Design comparison
Community feedback
- @fraserwatPosted almost 3 years ago
Hey Matheus! This is looking nice!
One thing I'd change would be to work through this article on centring divs. When you open your site on a smaller screen size the component is off the side of the screen so you'll need to centre that properly: How to Center Anything with CSS - Align a Div, Text, and More
Also would look at putting a light shadow on your component like they have on the design. If you're new to this function, there's loads of shadow generators to play around with you can copy the CSS into your code editor, like this one: Smooth Shadow
Good work! Fraser
0 - @anoshaahmedPosted almost 3 years ago
Hey good job on this challenge! Your report above shows a few issues though:
- wrap everything in your body in
<main>... OR use semantic tags! .... you can also giverole=""to the direct children of your<body>but that's a little frowned upon... Click here to read more - have at least one
<h1>in your code
Here's a link to something I wrote about accessibility issues & best practices
Hope this helps :)
0 - wrap everything in your body in
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord