QR code component

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 10 months ago

  Hello !

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is better to use rems and ems.

  font-size: 13px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Use <main> to wrap the main content instead of <div>. * 📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  ➖➖➖➖➖➖➖

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

  Other than that you're good, keep up the good work!

  Marked as helpful

  1

  ---

  

  aswinbhaskaran•60

  @aswinbhaskaranPosted 10 months ago

  @hassanmoaa What is the difference between rem, em and pt? I will definitely take your suggestions into account, but I am more comfortable with px. I may be wrong, but px allows me do value checking by dragging in the browser inspector before finalising on a value, if you get what I mean. If I am not wrong, em, rem, etc. do not allow for that to be accomplished. If I get a value finalised using px, I might need to manually change values at random later on to find the corresponding value with respect to rem, em, etc. Considering these, even the possible problems you had mentioned, I still feel px is comfortable for me.

  As for heading, with respect to this challenge, I wanted to use font-weight. In fact, I previously had a heading, that I had later on changed to normal text with font-weight. I personally feel there is no difference between headings and font-weight.

  Will change my current code so that it has a <main> section, following your suggestion.

  0

  

  aswinbhaskaran•60

  @aswinbhaskaranPosted 10 months ago

  @hassanmoaa Updated the solution. Please check it. I have made the changes, including px to rem.

  0

  

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  @aswinbhaskaran I recommend seeing this article:

  (https://fedmentor.dev/posts/font-size-px/)

  0

  

  aswinbhaskaran•60

  @aswinbhaskaranPosted 9 months ago

  @hassanmoaa Why does it feel that my changes are not enough with there still being some pending to be done, which is why you are suggesting me to read this article?

  0

  

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  @aswinbhaskaran

  Nope, you did a great job, im suggesting reading it so you get a whole better understanding about what i mean.

  Good Luck!

  0

  

  aswinbhaskaran•60

  @aswinbhaskaranPosted 9 months ago

  @hassanmoaa :thumbs-up:

  1