QR Code Component Main Using HTML and CSS

Community feedback

• 

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted 3 months ago

  Hello Yashi 👋, great job in completing this challenge. I noticed your card's (".frame" class) box-shadow doesn't match that of the given Figma design along with some minor spacing values.

  The' box-shadow' value is 0px 25px 25px rgba(0, 0, 0, 0.05). Here is a link to a picture showing how to get CSS values and more from a Figma design (assuming you don't have the Figma dev mode).

  Also, Frontend mentor have a great article on how to work with a design file, I recommend you check it out to learn more about this topic.

  I hope this was helpful to you, Shalom!

  Marked as helpful

  0

  ---

  

  Yashi Singh•340

  @Yashi-Singh-1Posted 3 months ago

  @IEdiong Thank You Ediong!

  0

  

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted 3 months ago

  @Yashi-Singh-1 You're welcome

  0

  

  Yashi Singh•340

  @Yashi-Singh-1Posted 3 months ago

  @IEdiong

  Hi Ediongsenyene,

  I hope you are doing well.

  I wanted to check with you regarding the height of the box. Do you think it's necessary to increase it, or should I keep it as is?

  Looking forward to your thoughts.

  Best Regards, Yashi Singh

  0

  

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted 3 months ago

  @Yashi-Singh-1

  Hi Yashi,

  It shouldn't be necessary. If you want the height of the box to match that of the design you should focus on making the elements inside have the correct line height, margin and padding (including the box), this would automatically make the box have the said height as shown in the design.

  Those are my thoughts.

  0

  

  Yashi Singh•340

  @Yashi-Singh-1Posted 3 months ago

  @IEdiong Thanks, Buddy!

  If you don't mind could we connect over Linkedin?

  0

  

  Ediongsenyene Joseph I.•1,675

  @IEdiongPosted 3 months ago

  @Yashi-Singh-1

  You're welcome.

  Sure, my LinkedIn profile is on my FEM profile.

  0