QR Code Component Main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Claudio, You have done a good work! 😁

  Some little tips to improve your code:

  • use article tag to wrap the card and improve the Accessibility but not as a container of that one element inside card
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the figure container of image
  • remove all width from body
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Claudio Roberto•170

  @claudio-dev1993Posted almost 2 years ago

  @denielden Thank you for replying my solution and share some tips. Surely i'll review my code and fix the wrong points as you suggest.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @claudio-dev1993 you are welcome and keep it up :)

  0