Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component Main

@claudio-dev1993

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hello Claudio, You have done a good work! 😁

Some little tips to improve your code:

  • use article tag to wrap the card and improve the Accessibility but not as a container of that one element inside card
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the figure container of image
  • remove all width from body
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

Marked as helpful

1

@claudio-dev1993

Posted

@denielden Thank you for replying my solution and share some tips. Surely i'll review my code and fix the wrong points as you suggest.

1
Travolgi 🍕 31,420

@denielden

Posted

@claudio-dev1993 you are welcome and keep it up :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord