Qr code component main

Community feedback

• 

  Mihirkumar hitendrabhai nayak•180

  @mihir2226Posted over 1 year ago

  you did great work friend. but it looks better if you just give a little line height in the heading and text.

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  CSS 🎨:

  • Use min-height instead of height. Setting the height to 90vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

    screenshot-imgur (landscape mode)📸

  I hope you find it useful! 😄

  Happy coding!

  0