QR Code component main

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <h2> with <h1> to fix the accessibility issue. Always begin the heading of the html with <h1> tag because the <h1> is needed to make the content accessible, wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .qrcode on the page using grid, replace the height in the body with min-height: 100vh.

  Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Siraj Sharma•150

  @sirajsharmaPosted over 1 year ago

  @Hassiai Thank you for the suggestions. I'll keep these things in mind.

  0