QR Code Component Main

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page using flexbox or grid instead of position, absolute,add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  USING FLEXBOX:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  USING GRID:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content, replace the width in .container and .qr with max-width.

  Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center,the same margin-left, margin-right and margin-top values. Give p a margin bottom value and a font-color of hsl(220, 15%, 55%).

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  adammmmd•20

  @adammmmdPosted over 1 year ago

  @Hassiai thank you so much for your feedback! I'm a self learner and no one ever told me this 😵. Thank you 🙏

  1