Design comparison
Solution retrospective
What I learned Just learning how to use Figma. This project was a nice intro to that!
Continued development Always looking for best practices especially in regards to accessibility and responsivity. Any feedback received may be added here at a later date.
What challenges did you encounter, and how did you overcome them?Still working out how to properly use Figma since I upped my account to a paid sub.
What specific areas of your project would you like help with?I'm still having some "issues" with vertical alignment - if they are indeed actually issues. My images aren't always lining up well in the slider comparison window.
Community feedback
- @Islandstone89Posted 7 months ago
Hi, great job!
Some suggestions:
HTML:
- The alt text must also say where it leads(frontendmentor website).
CSS:
-
Including a CSS Reset at the top is good practice.
-
Add around
1rem
ofpadding
on thebody
, so the card doesn't touch the edges on small screens. -
On the
body
, changeheight
tomin-height
- this way, the content will not get cut off if it grows beneath the viewport. -
I would move the properties on
.wrapper
to thebody
. You don't need to declarenowrap
, as that is the default value forflex-wrap
. -
Remove the
width
on the card. Instead, give it amax-width
of around20rem
to prevent it from getting too wide on larger screens. -
On the image, remove the
width
andheight
. Adddisplay: block
andmax-width: 100%
- the max-width prevents it from overflowing its container.
Marked as helpful0@salentipyPosted 7 months ago@Islandstone89 Thanks so much! I made all the changes you suggested. (I always get mixed up when to use min- and max-heights and widths and such. Not sure why I have a hard time with that.) I didn't change the CSS reset. I started looking into that, and it sent me off into hours of different rabbit holes! I need to do some more research into the best way to do that. Thanks again for the feedback! Much appreciated!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord