Skip to content
Submitted over 1 year ago

qr code component main

Armando Echeverria Gallardo•90
@ArmadnoeG
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

hello,

All feedbacks are welcome :).

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted over 1 year ago

    Hi Armando, congrats🎉 on completing the challenge. Better take care about following points.

    To avoid accessibility issue "All page content should be contained by landmarks" use code as :

    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why main matters? Read here)

    • For proper centering the container(whole card) vertically and horizontally you can use code as:
    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

    (in your code after using above block of code just remove following block for proper centered display)

    .container {
     display: flex;
     align-items: center;
     justify-content: center;
     height: 150vh;
}
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    Hope you will find this Feedback Helpful.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord