Design comparison
SolutionDesign
Solution retrospective
Any feedback for me to improve this "QR Code Component Main" challenge?
Community feedback
- @purnimakumarrPosted over 2 years ago
Hi Draco,
I would suggest these changes.
- You should put your main content in a
<main></main>
tag as it is a good practice to use HTML5 sematic tags. It makes your code more accessible. So your code would be something like
<main> <div class="container"> qr card goes here </div> </main>
-
Also you should use an
<h1></h1>
tag for the first heading of your webpage. Here it is the title "Improve your front-end skills by building projects". So I would suggest replacing the<p class="title"></p>
with an<h1></h1>
-
Also, I see that you are using inline style on the
<img />
tag. You can simply put that code in you styles.css file.
Marked as helpful1 - You should put your main content in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord