Hrid Chakraborty• 60
@hrid-chakraborty
Posted
I would like to start by saying that you have built the QR component really well.
Here are some observations/suggestions which I hope are helpful:
- When opening the website, the card appears on the bottom middle section of the page instead of the center.
- When resizing the window, the card is appearing on the left of the page. (Hint: both these problems can be solved using flexbox )
- It would be best practice to put the styles in a separate .css file. Improves code readability.
- Just a small nitpick, but it would look much nicer if some more padding is added inside the card. Also, you could use custom fonts (like Outline from style-guide.md) from Google fonts.
Overall, the component looks really nice. I hope my feedback has been helpful.
0
