
Design comparison
Community feedback
- P@dev-ethanjohnPosted about 1 month ago
The UI component fits nicely and identical enough.
I have suggestion though for you to consider or look at. You can use semantic elements instead of relying mostly on
div
s in structuring your HTML. for example, you can use anarticle
tag for the overall card. Afigure
tag to wrap your qr image. And anh1
for the title instead of using div with a descriptive class. This is will any sites to perform better particularly for SEO and accessibility. You may check this https://www.semrush.com/blog/semantic-html5-guide/ for a guide or from MDN/web.dev sites on semantic elementsHope it helps!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord