qr code component main

Community feedback

• 

  P

  Fluffy Kas•7,695

  @FluffyKasPosted about 1 year ago

  Heyo,

  Your solution looks nice! There's a few small things you could check though.

  • your QR code image is missing its alt text
  • Regarding Tailwind: there are built-in Tailwind classes for both of these: h-[100%] and h-[100vh], these would be h-full and h-screen if I recall correctly. but heights shouldn't really be fixed anyway, so a min-h-full/min-h-screen would be better suited.
  • bg-[#d5e1ef] => Things like colours or other variables that you may reuse in the future should be ideally set in the tailwind config file

  All in all, good job on this one!

  1

  ---

  

  Aman Khan•10

  @AmanAdastraPosted about 1 year ago

  Thanks @FluffyKas. Your Feedback is much appreciated.

  0