Qr Code Component Main

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey Ameer, Congratulations on completing this challenge... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="background">
        //...
     </div >
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • I suggest you center the component on the page, by giving the parent element <main> the following properties:

  
  main {
     display: flex;
     justify-content: center;
     align-items: center;
     min-height: 100vh;
   }  
  
  .background {
      /* position: relative; */      <--- Remove
      /* top: 9rem; *   /            <--- Remove
      /* display: inline-block; */   <--- Remove
      //...
  }
  

  I hope this is useful to you... Keep coding👍

  1

  ---

  

  Ameer Hamza•60

  @AmeerHamza838Posted over 2 years ago

  @Bayoumi-dev Thank You So Much. I will really try to these issues. Actually This was my first experience. I will make my code better.

  0

  

  Ameer Hamza•60

  @AmeerHamza838Posted over 2 years ago

  @Bayoumi-dev Thank You so much for helping me out. I really fixed it.

  0