QR code component Main

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  👾Hello Christian, congratulations for your solution!

  With this photo you've I don't think you need to improve nothing, is just the best profile picture here, I like this meme!

  But if you want to improve the responsiveness a bit, you can remove all width from the other divs and control everything using only the main width max-width: 320px after doing that you'll see that the container will be responsive.

  Hope it helps and happy coding!

  Marked as helpful

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted over 2 years ago

  Good Job!

  Some Suggestions:

  Delete the container and main classes you created, you already have a main element; no need to bury your code any further.

  In your card class, delete the height (the content itself will create it) , delete anything flex related (your content is already vertically aligned, by default), change your width to 320px and your padding-top to padding: 16px

  For your image remove the padding; not necessary.

  Lastly, for your text content, place them both in a container their individual padding and play around with the padding/margin for the container till it looks the FEM (frontendmentor) demo.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Christian•70

  @meme-devPosted over 2 years ago

  @vcarames noted thanks man! <3

  0