qr code component main

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, just a couple of things that may interest you:

  • The main content of every page (the card in this case) should be wrapped with the <main> tag.

  • You might consider using relative units like rem or em since they are better for scalable layouts. Something simple to start with would be to convert to rem (1 rem equals the font size of the root element, 16px by default). Consider this suggestion especially for the font-size.

  • If you've already studied grid or flex, consider using it to center the card on the page instead of the method you chose, for example like this:

  body {
  min-height: 100vh;
  display: grid;
  place-content: center;
  }
  

  And in this way you will avoid the page to be cut off in viewports with small height (such as mobile landscape orientation).

  I hope it’s useful : )

  Regards,

  Marked as helpful

  1

  ---

  

  Ali-El-Shoraa•130

  @Ali-El-ShoraaPosted over 1 year ago

  Thank you very much I will take your advice on everything you said @fernandolapaz

  1
• 

  El Mehdi El fatihi•120

  @mehdilightPosted over 1 year ago

  It looks good, but I noticed that the text color of the heading is not the same one used in the design.

  0

  ---

  

  Ali-El-Shoraa•130

  @Ali-El-ShoraaPosted over 1 year ago

  I try to look like the one in the design as much as possible, thank you @mehdilight

  0