@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have other suggestions about your code that might interest you.
HTML π·οΈ:
- Wrap the page's whole main content in the
<main>
tag.
Alt text π·:
-
To make the alt attribute as useful and effective as possible, avoid using words such as "image", "photo", or "picture" as they are redundant because the image tag already conveys that information. Instead, try to make the description as human-readable and understandable as possible.
The alt attribute should explain the purpose of the image, for example, in the case of a QR code, a description like "qr code to frontendmentor.io" would be more appropriate.
If you want to learn more about the
alt
attribute, you can read this article. π.
CSS π¨:
- You don't need to add
font-family: "Outfit", sans-serif;
to each<p>
,<h*>
separately. Instead, add it to body.
- It's not a big problem but the
display: block;
style on the.white-border
element is unnecessary, that value is the default for the div tag.
CSS Reset π:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@Damuzid
Posted
@MelvinAguilar Thank you for the feedback. Very usefull for the next challenge, especially the CSS Reset.
I was looking at your solutions and I was wondering how you're getting the exact sizes to use? I tried examining the images in Photoshop but I always tend to end up a bit to large.
@MelvinAguilar
Posted
@Damuzid Hello!! I use an extension called PerfectPixel to put the preview image on top of the solution I'm making, then I simulate a screen (1440px wide) using dev tools so it looks as close as possible.
Another option is to upgrade to Premium in order to view the Figma files containing the precise values.
Marked as helpful