QR code component made with css Flexbox

Community feedback

• 

  Nnoruka Maryjane .C•120

  @emjayrukaPosted 9 months ago

  Hey azgpapi. I'd like to offer some constructive feedback that may enhance the overall structure and functionality of your work. It seems the project relies heavily on generic <div> tags rather than utilizing semantic HTML elements such as <main>, <nav>, and <footer>. Incorporating these elements can significantly improve the document's structure, making it more accessible and easier to understand. For example, the <div.container> could be replaced with a <main> tag while the <div.box> could be replaced with a <footer> tag.

  I also noticed an issue with image linking, as your image doesn't seem to load correctly. Ensure that you are using the correct file paths or URLs.

  I'd also like to offer a gentle reminder to consider following style guidelines more closely.

  I believe these adjustments will benefit your future projects and also contribute to their overall accessibility and maintainability.

  I hope I was of help.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  azgpapi•90

  @azgpapiPosted 9 months ago

  @emjayruka Really appreciate your site, to be honest I am a beginner and I already know I have a problem of structuring my html elements very correctly. That's why I need your comment very much. Thank you and I am also working on structuring correctly.

  0
• 

  P

  Justin Connell•720

  @justinconnellPosted 9 months ago

  Hi @azgpapi,

  I noticed your solution is broken and took a look at the source code... (as opposed to taking a wild guess)

  The problem is this line of code: <img src="images/image-qr-code.png" alt="" />

  The image is in the root of your website - there is no images folder in the repo - so there are 2 ways to fix this - either change the link to the image, or move the image to a directory named 'images'

  I hope that you find my comment helpful.

  all the best, Justin

  0

  ---

  

  azgpapi•90

  @azgpapiPosted 9 months ago

  @justinconnell Yes, but the problem when I was pushing I think, it was present in the first place. And thank you for your help.

  0
• 

  yoy•100

  @yoyfordPosted 9 months ago

  hi,i think theres no css file

  0