QR Code component made using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Gurditt Singh Khurana•10

  @gurdittcancodePosted over 1 year ago

  @0xAbdulKhalid Thanks, I'll surely keep these points in mind

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @gurdittcancode Glad you found it helpful ! 🤠

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  hey there,

  good work in completing the challenge successfully!

  Q: "I would love to know how I can make this responsive."

  Answer: You can use media queries to change your layout based on browser size. A very basic example:

  @media only screen and (max-width: 600px) { .your-container { flex-direction: column; } }

  and don't forget to adjust the individual column widths back to 100% or simply remove 50%.

  You can read more about here: https://www.w3schools.com/css/css_rwd_mediaqueries.asp

  Hope you find this feedback helpful!

  Marked as helpful

  1