QR code component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi , congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  0
• 

  Med Amine Ck•10

  @MedAmineCkPosted about 2 years ago

  you need to add a font to the text and make the image a little bit bigger, try those sizes for the card width: 325px; height: 500px; and for the image put it inside a container and make it 100% and for the main card add padding: 20px; and you need to fix some HTML errors

  0
• 

  Taro Chilongoshi•40

  @TchiloPosted about 2 years ago

  Hi @whyski008

  Great solution and a great start! From what I have seen you’re on the right track. Here are a few suggestions for you that you can consider adding to your code:

  Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning. The main heading has the tag <h3>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

  Here is an article on freecodecamp on semantics I hope it helps out: Semantic HTML5 Elements Explained

  ✌️ I hope this helps you and happy coding!

  0