Design comparison
Solution retrospective
Hi guys, it's a pleasure to be part of this community.
I just finished my first challenge!
Could you give me some feedback?
Thanks in advance!
Community feedback
- @MelakuAlehegnPosted over 1 year ago
Hello there @Zeuqram24. Congratulations on successfully completing the challenge! 🎉
I have other recommendations regarding your code that I believe will be of great interest to you. This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors. What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers For example: The <main> element should include all content directly related to the page's main idea, so there should only be one per page So resolve the issue by replacing the <div class="main-container"> element with the proper semantic element <main> along with element in your index.html file to improve accessibility and organization of your page.
I hope you find this helpful. Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord