Skip to content
Submitted about 2 years ago

QR code component

Bentsiwa•60
@Miss-Bentil
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello I am quite new at this. So please help make any corrections if need be. Thank you

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hi Bentsiwa, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

    The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, decorations and optimize it making easier to work,see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Bentsiwa•60
    @Miss-BentilPosted about 2 years ago

    @correlucas thank you Lucas

    0
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Bentsiwa, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    To further improve the responsiveness of the project, we can do the following:

    withdrew:

    @media (max-width: 500px)
.container {
    /* width: 400px; */
}

    Do the test!

    The rest is great!

    Hope it helps...👍

    Marked as helpful
    0
    Bentsiwa•60
    @Miss-BentilPosted about 2 years ago

    @AdrianoEscarabote Hello Adriano it helps thank you 🙏🏾

    1
    Bentsiwa•60
    @Miss-BentilPosted about 2 years ago

    @AdrianoEscarabote Hii sorry. Could you explain that… because what you just typed for the media query is the same as the one in the code

    1
    Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    @Miss-Bentil yes, but I commented out the code, comment the code I commented and test the responsiveness!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord