Design comparison
Solution retrospective
I found it difficult to ensure the responsiveness on mobile devices. Can you advice me on how to make sites more responsive?
Community feedback
- @MiyaoCatPosted 10 months ago
I think this specific challenge really only asks for one size. The QR code card seemed like it was the same size on mobile and desktop. But for other challenges, I recommend building the site on the mobile size first (mobile-first development).
A couple things I noticed:
font-weight: bold;
Bold is not a declaration. You'll want to use a numbered weight. For this challenge, the weights were 400 and 700, 700 is for bold. (The higher the weight the bolder the text)- For your QR code image, you can remove the height or set it to auto. That way when the screen is wider/larger it wont stretch vertically.
Those were the only two improvements I'd reccommend. Otherwise everything looks great!
Marked as helpful0 - @danielmrz-devPosted 10 months ago
Hello @repro123!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
š Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful0 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord