QR code component

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

• For example:
• The <main> element should include all content directly related to the page's main idea, so there should only be one per page
• The <footer> typically contains information about the author of the section, copyright data or links to related documents.

• So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Congratulations on completing the challenge! 🎉.That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote.

You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further.

change the background color of body tag

body {
background-color: hsl(212, 45%, 89%);
}

and add width:100vw to make the footer center or u can use flexbox also

.attribution {
text-align: center;
position: absolute;
bottom: 10px;
right: 10px;
width: 100vw;
}

Quick FYI: Your link to the source code is not working.

When I click on it, Gitlab sends me a 404. Your preview-site link does work though.