@lunanguyen
Posted
Your code overall is well-structured and readable. You've used semantic HTML elements appropriately, which is great for accessibility and SEO. Here are some constructive feedback points: Semantic HTML: You've used <main>, <section>, <aside>, and <footer> tags appropriately, which is excellent for semantic HTML. However, consider using more descriptive class names than just "qr" and "qr__image" to improve readability and maintainability. Responsiveness: The layout seems responsive, as you've used max-width for the .qr__image class and max-width for the .qr class. However, you may want to consider using relative units like em, rem, or percentages for font sizes to ensure better scalability across different screen sizes and resolutions. Font Loading: You're importing a Google Font in your CSS file, which is good. However, consider adding a fallback font-family in case the Google Font fails to load for some reason. This ensures a better user experience even if the font doesn't load.
Marked as helpful
@craigdev937
Posted
@lunanguyen - Hi Luna, thanks for your suggestions. I will look into them going forward. 😉
