@vanzasetia
Posted
Hi, Abu! π
Congratulations on finishing this challenge! π
Here are some suggestions for improvements.
- The alternative text for the QR can be improved by giving some information about the QR code. In this case, it is going to navigate the users to https://www.frontendmentor.io/ after they scan the QR code. So, the better alternative is something like "QR code to frontendmentor.io".
- Put the attribution below the card. Change the
flex-direction
of the flex container (body
) tocolumn
. Then, remove thedisplay: flex;
from the.attribution
. - I recommend wrapping the card with the
main
landmark. For the attribution, it should be wrapped withfooter
because it is not the main content of the page. - Never set
max-width
on thebody
element. It should always be filling the entire page. You should only limit the width of the elements inside thebody
element. - Remove
height
from thebody
element too. Thebody
element should always fill the entire page. Treat it as the main element of the web page. - Remove
hieght
from the.container
or the card. Let the elements inside the card control its height of it. - Prefer unitless numbers for line-height values to avoid unexpected results. The MDN documentation of
line-height
explains it well.
I hope this helps! Happy coding!
Marked as helpful
@AbuKesh
Posted
@vanzasetia Thank you, for your suggestions. I will look into this and edit my solution. But about that removing height from the body element, I tried it first but without giving the height to the body that container is not placing in the middle of the body vertically. So, thats why I have given the height to the body.
@vanzasetia
Posted
@AbuKesh You are welcome! π
You can set min-height: 100vh
instead. This way, if the card needs more than 100vh, then the body
element can grow to fit the content.