Skip to content
Submitted almost 2 years ago

QR solution

od•80
@oguerid
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

hi is it possible to get any feedback if i done this correctly as this is my first project it would nice to know if there other way to do this.

Community feedback

  • Shahjahan Sarfraz•270
    @Jahan-ShahPosted almost 2 years ago

    Hi, there well done on completing the challenge. I have left some feedback below if you want to improve more.

    In HTML:

    -You must use only one h1 in your page. You can make it visually hidden by adding a class="sr-only" to h1 and adding this css to hide it visually from the page.

    -Use Semantic Elements (i.e. <main>, <section>) instead of divs to improve accessibility.

    -Use <footer> element instead of <div class="attribution">. And move it out of the card and place it after the <main> element in the body.

    -Always use alt attribute for images to make it more accessible for screen readers.

    In CSS:

    -Use rem or em for font-size instead of px. As pixel is an absolute value it doesn't scale with the browser.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord