Shahjahan Sarfraz• 270
@Jahan-Shah
Posted
Hi, there well done on completing the challenge. I have left some feedback below if you want to improve more.
In HTML:
-You must use only one h1 in your page. You can make it visually hidden by adding a class="sr-only" to h1 and adding this css to hide it visually from the page.
-Use Semantic Elements (i.e. <main>, <section>) instead of divs to improve accessibility.
-Use <footer> element instead of <div class="attribution">. And move it out of the card and place it after the <main> element in the body.
-Always use alt attribute for images to make it more accessible for screen readers.
In CSS:
-Use rem or em for font-size instead of px. As pixel is an absolute value it doesn't scale with the browser.
0
