Skip to content
Submitted almost 2 years ago

qr-code-component-main

Davis•330
@davislocs
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey. This is my second project. In general i think i did it well, but if there is something i should improve on, feedback is appreciated. : )

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Replace <p class="bold"> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

    Use rem or em as unit for the padding, margin and width values for more on CSS unit watch this https://youtu.be/N5wpD9Ov_To

    Hope am helpful HAPPY CODING

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord